Support for non-default dataclass fields #116
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This is small change, any reason why this is not merged? |
|
This looks all fine, but needs a rebase and some minor renames/etc. I'll go ahead and do it, and see how CI reacts. |
bsipocz
force-pushed
the
dataclass-nondefault-fields
branch
from
c83e14f
to
91f6fc5
Compare
Codecov Report
@@ Coverage Diff @@
## main #116 +/- ##
==========================================
- Coverage 89.83% 89.38% -0.45%
==========================================
Files 27 27
Lines 1141 1168 +27
==========================================
+ Hits 1025 1044 +19
- Misses 116 124 +8
📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
bsipocz
reviewed
Apr 13, 2023
Comment on lines
+67
to
+75
| if dataclasses.is_dataclass(obj): | ||
| if attr in obj.__dataclass_fields__: | ||
| return obj.__dataclass_fields__[attr].name | ||
| else: | ||
| # raise original AttributeError | ||
| raise e | ||
| else: | ||
| # raise original AttributeError | ||
| raise e |
There was a problem hiding this comment.
The logic here could be simplified a bit and all put into one conditional and a raise outside of it.
| return getattr(obj, attr, *defargs) | ||
| try: | ||
| return getattr(obj, attr, *defargs) | ||
| except AttributeError as e: |
There was a problem hiding this comment.
extreme nitpick: it's best to avoid single-letter variables and use something descriptive, even when the single letter feels trivial.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this PR tries to fix this issue: #115.
Used sphinx version: 3.2.1
Python version: 3.8.5
Fix #115